fix(typesutil): fix type checker returned an unexpected error #2426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the type checker could return an unexpected error by implementing proper error handling and recovery mechanisms. The fix ensures that when type checking fails during statement compilation, the system can gracefully handle the error and continue processing.
Key changes:
- Added an error handler parameter to the type checking infrastructure
- Implemented deferred recovery blocks in statement compilation functions
- Reorganized the order of
cb.End()calls to use defer statements for proper cleanup
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| x/typesutil/check_test.go | Adds error handling infrastructure and test case to verify proper error handling during type checking |
| cl/stmt.go | Implements deferred recovery blocks in statement compilation functions to handle panics gracefully |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
visualfc
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: nighca/builder-experience#32
fix: goplus/builder#2012