fix(typesutil): use xgo types error #2428
Merged
+39
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes type error handling in the xgo types utility by introducing a custom Error type that mimics the standard Go types.Error interface. The change ensures consistent error handling between Go and xgo type checking by providing proper error conversion functions.
- Introduces a new Error type with position information and error formatting
- Updates error conversion functions to use the new Error type instead of types.Error
- Adds error handling wrapper for Go type checker to convert errors to the new format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| x/typesutil/gopinfo.go | Adds new Error type definition with position tracking and error formatting |
| x/typesutil/check.go | Updates error handling to use new Error type and adds Go error conversion |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
types.Error does not have End, but has go116end. If the language server needs to use end, it must use reflection, which has poor performance. Alternatively, it can use the unsafe package, which is also not very safe. Therefore, xgo is considering providing its own Error.