Thanks to visit codestin.com
Credit goes to github.com

Skip to content

workflows: go1.25 #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xushiwei merged 1 commit into from
Sep 26, 2025
Merged

workflows: go1.25 #2438

xushiwei merged 1 commit into from
Sep 26, 2025

Conversation

@visualfc
Copy link
Member

@visualfc visualfc commented Sep 19, 2025

No description provided.

@niupilot
Copy link
Contributor

niupilot bot commented Sep 19, 2025 •
edited
Loading

PR Review: workflows: go1.25

Review Summary

This PR adds Go 1.25 support to the CI workflows and fixes a test condition for Go version compatibility. The changes are straightforward and well-targeted.

Changes Analyzed

  1. .github/workflows/go.yml: Added 1.25.x to the Go version matrix for both Test and TestTypeAlias jobs
  2. cl/typeparams_test.go:346: Changed condition from go1point == 24 to go1point >= 24 to handle Go 1.25+ properly

Issues Found

Missing Go version consistency: The FormatCheck job still uses a hardcoded Go version 1.24.2 (.github/workflows/go.yml:100) while other jobs now test up to Go 1.25. This creates an inconsistency where the format checker isn't using the latest supported Go version.

Test logic assumption: The change from == 24 to >= 24 assumes that Go 1.25+ will have the same error message format as Go 1.24. This should be verified or the test should be updated to handle version-specific cases explicitly.

Recommendations

  1. Consider updating the FormatCheck job to use Go 1.25 or at least 1.24.x for consistency
  2. Verify that the error message format assumption holds true for Go 1.25
  3. The workflow changes look correct for adding Go 1.25 support

Overall Assessment: This is a clean PR that properly adds Go 1.25 support with the necessary test compatibility fix. The identified issues are minor consistency concerns that should be addressed for robustness.

👉 Want me to re-run this review? Just type /review in the comments! For more usage examples, visit CodeAgent GitHub Repository.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Sep 19, 2025

Summary of Changes

Hello @visualfc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compatibility for a specific test case by adjusting its expected error message format. The change ensures that the test TestTypeParamsErrInferFunc functions correctly across Go versions, specifically accommodating formatting differences introduced in Go 1.24 and continuing into Go 1.25.

Highlights

  • Test Compatibility Update: The TestTypeParamsErrInferFunc test has been updated to correctly handle changes in error message formatting for Go versions 1.24 and above, ensuring the test remains accurate with newer Go toolchains.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 19, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a test to support Go 1.25 by changing a version check from go1point == 24 to go1point >= 24. This ensures that the test accommodates for an error message format that was introduced in Go 1.24 and is expected to persist in future versions. The change is correct and follows the established pattern for handling version-specific test expectations in this file. I find no issues with this modification.

@xushiwei xushiwei merged commit 454ba52 into goplus:main Sep 26, 2025
29 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@visualfc @xushiwei