ci: remove deprecated VERSION file dependency from release workflow #2535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VERSION file is no longer used after implementing automated version management via debug.ReadBuildInfo() and ldflags injection. This removes the VERSION consistency check step and updates the pre-release check to use the TAG_NAME environment variable directly. Fixes #2525 Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: cpunion <[email protected]>
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2535 +/- ##
=======================================
Coverage 93.98% 93.98%
=======================================
Files 34 34
Lines 9631 9631
=======================================
Hits 9052 9052
Misses 414 414
Partials 165 165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @cpunion
Summary
Context
The VERSION file was deprecated as part of the automated version management implementation (see #2521). The release CI workflow was still attempting to read from this file, causing the build to fail with
cat: VERSION: No such file or directory.Fixes #2525