feat!: remove auto-snapshot on dirty tag #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos A Becker <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
==========================================
- Coverage 66.14% 65.04% -1.10%
==========================================
Files 4 3 -1
Lines 127 103 -24
Branches 23 17 -6
==========================================
- Hits 84 67 -17
+ Misses 25 23 -2
+ Partials 18 13 -5 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Carlos A Becker <[email protected]>
Signed-off-by: Carlos A Becker <[email protected]>
Signed-off-by: Carlos A Becker <[email protected]>
Signed-off-by: Carlos A Becker <[email protected]>
|
Sorry didn't have time to review this 😣 but lgtm |
|
No worries ❤️ |
|
Can I get the previous behavior of using snapshot if dirty and version of tagged by adding |
|
there's a FWIW: I do something similar here https://github.com/caarlos0/goreleaser-pro-split-merge-example/blob/99553a5ca10b82335ae995083210957bb574ff8a/.github/workflows/nightly.yml#L23 for nightly on |
estahn
pushed a commit
to estahn/k8s-image-swapper
that referenced
this pull request
Jan 1, 2023
## [1.4.0](v1.3.3...v1.4.0) (2023-01-01) ### 👷 Build System * **deps-dev:** Bump @semantic-release/changelog from 6.0.1 to 6.0.2 ([#404](#404)) ([ee56dbc](ee56dbc)), closes [#276](#276) [#276](#276) [#272](#272) [#275](#275) [#273](#273) [#274](#274) [#271](#271) [#270](#270) [#269](#269) [#268](#268) [#267](#267) ### 🎉 Features * add custom tags to created ECR repositories ([#191](#191)) ([9849df2](9849df2)) ### 📝 Documentation * fix indentation ([b00c57e](b00c57e)) ### ⬆️ Dependencies * **deps:** Bump actions/cache from 3.0.11 to 3.2.1 ([#417](#417)) ([7e7eb8f](7e7eb8f)), closes [actions/cache#1039](actions/cache#1039) [actions/cache#1023](actions/cache#1023) [actions/cache#959](actions/cache#959) [actions/cache#960](actions/cache#960) [actions/cache#963](actions/cache#963) [actions/cache#961](actions/cache#961) [actions/cache#976](actions/cache#976) [actions/cache#971](actions/cache#971) [actions/cache#979](actions/cache#979) [actions/cache#986](actions/cache#986) [actions/cache#981](actions/cache#981) [actions/cache#997](actions/cache#997) [actions/cache#998](actions/cache#998) [actions/cache#1005](actions/cache#1005) [actions/cache#1007](actions/cache#1007) [actions/cache#1013](actions/cache#1013) [actions/cache#1004](actions/cache#1004) [actions/cache#1014](actions/cache#1014) [actions/cache#1008](actions/cache#1008) [actions/cache#1026](actions/cache#1026) [actions/cache#929](actions/cache#929) [actions/cache#1035](actions/cache#1035) [actions/cache#959](actions/cache#959) [actions/cache#979](actions/cache#979) [actions/cache#1013](actions/cache#1013) [actions/cache#1026](actions/cache#1026) [actions/cache#929](actions/cache#929) [actions/cache#1006](actions/cache#1006) [#1023](https://github.com/estahn/k8s-image-swapper/issues/1023) [#1039](https://github.com/estahn/k8s-image-swapper/issues/1039) [#1035](https://github.com/estahn/k8s-image-swapper/issues/1035) [#929](#929) [#1026](https://github.com/estahn/k8s-image-swapper/issues/1026) [#1008](https://github.com/estahn/k8s-image-swapper/issues/1008) [#1014](https://github.com/estahn/k8s-image-swapper/issues/1014) [#1004](https://github.com/estahn/k8s-image-swapper/issues/1004) * **deps:** Bump actions/setup-python from 4.3.0 to 4.3.1 ([#406](#406)) ([16da762](16da762)), closes [actions/setup-python#559](actions/setup-python#559) [actions/setup-python#511](actions/setup-python#511) [actions/setup-python#558](actions/setup-python#558) [#559](#559) [#558](#558) [#549](#549) [#546](#546) [#545](#545) [#535](#535) [#510](#510) [#511](#511) [#520](#520) * **deps:** Bump actions/setup-python from 4.3.1 to 4.4.0 ([#418](#418)) ([77872f8](77872f8)), closes [actions/setup-python#566](actions/setup-python#566) [#567](#567) [#569](#569) [#566](#566) * **deps:** Bump github.com/aws/aws-sdk-go from 1.44.146 to 1.44.152 ([#403](#403)) ([9db51fd](9db51fd)), closes [#4652](https://github.com/estahn/k8s-image-swapper/issues/4652) [#4650](https://github.com/estahn/k8s-image-swapper/issues/4650) [#4648](https://github.com/estahn/k8s-image-swapper/issues/4648) [#4647](https://github.com/estahn/k8s-image-swapper/issues/4647) [#4646](https://github.com/estahn/k8s-image-swapper/issues/4646) [#4644](https://github.com/estahn/k8s-image-swapper/issues/4644) [#4639](https://github.com/estahn/k8s-image-swapper/issues/4639) * **deps:** Bump github.com/aws/aws-sdk-go from 1.44.152 to 1.44.157 ([#411](#411)) ([2188432](2188432)), closes [#4658](https://github.com/estahn/k8s-image-swapper/issues/4658) [#4657](https://github.com/estahn/k8s-image-swapper/issues/4657) [#4656](https://github.com/estahn/k8s-image-swapper/issues/4656) [#4654](https://github.com/estahn/k8s-image-swapper/issues/4654) [#4653](https://github.com/estahn/k8s-image-swapper/issues/4653) * **deps:** Bump github.com/aws/aws-sdk-go from 1.44.157 to 1.44.162 ([#415](#415)) ([f70fcd9](f70fcd9)), closes [#4666](https://github.com/estahn/k8s-image-swapper/issues/4666) [#4665](https://github.com/estahn/k8s-image-swapper/issues/4665) [#4663](https://github.com/estahn/k8s-image-swapper/issues/4663) [#4661](https://github.com/estahn/k8s-image-swapper/issues/4661) [#4660](https://github.com/estahn/k8s-image-swapper/issues/4660) * **deps:** Bump github.com/aws/aws-sdk-go from 1.44.162 to 1.44.167 ([#419](#419)) ([f8b91fe](f8b91fe)), closes [#4671](https://github.com/estahn/k8s-image-swapper/issues/4671) [#4670](https://github.com/estahn/k8s-image-swapper/issues/4670) [#4669](https://github.com/estahn/k8s-image-swapper/issues/4669) [#4668](https://github.com/estahn/k8s-image-swapper/issues/4668) [#4667](https://github.com/estahn/k8s-image-swapper/issues/4667) * **deps:** Bump github.com/gruntwork-io/terratest from 0.41.3 to 0.41.4 ([#402](#402)) ([16dde07](16dde07)), closes [#1208](https://github.com/estahn/k8s-image-swapper/issues/1208) * **deps:** Bump github.com/gruntwork-io/terratest from 0.41.4 to 0.41.6 ([#409](#409)) ([9fc87df](9fc87df)), closes [#1214](https://github.com/estahn/k8s-image-swapper/issues/1214) [#1198](https://github.com/estahn/k8s-image-swapper/issues/1198) * **deps:** Bump github.com/gruntwork-io/terratest from 0.41.6 to 0.41.7 ([#420](#420)) ([9ab97f2](9ab97f2)), closes [gruntwork-io/terratest#1217](gruntwork-io/terratest#1217) [#1217](https://github.com/estahn/k8s-image-swapper/issues/1217) * **deps:** Bump goreleaser/goreleaser-action from 3.1.0 to 4.1.0 ([#414](#414)) ([e963ba1](e963ba1)), closes [goreleaser/goreleaser-action#382](goreleaser/goreleaser-action#382) [goreleaser/goreleaser-action#366](goreleaser/goreleaser-action#366) [goreleaser/goreleaser-action#379](goreleaser/goreleaser-action#379) [goreleaser/goreleaser-action#383](goreleaser/goreleaser-action#383) [goreleaser/goreleaser-action#366](goreleaser/goreleaser-action#366) [goreleaser/goreleaser-action#379](goreleaser/goreleaser-action#379) [goreleaser/goreleaser-action#370](goreleaser/goreleaser-action#370) [#374](#374) [#372](#372) [#373](#373) [#383](#383) [#366](#366) [#382](#382) [#370](#370) * **deps:** Bump k8s.io/api from 0.25.4 to 0.26.0 ([#407](#407)) ([d13bf5e](d13bf5e)), closes [#111023](https://github.com/estahn/k8s-image-swapper/issues/111023) [#113375](https://github.com/estahn/k8s-image-swapper/issues/113375) [#113186](https://github.com/estahn/k8s-image-swapper/issues/113186) * **deps:** Bump k8s.io/client-go from 0.25.4 to 0.26.0 ([#410](#410)) ([bcc56b5](bcc56b5)), closes [#113797](https://github.com/estahn/k8s-image-swapper/issues/113797) [#111023](https://github.com/estahn/k8s-image-swapper/issues/111023) [#113826](https://github.com/estahn/k8s-image-swapper/issues/113826) [#113375](https://github.com/estahn/k8s-image-swapper/issues/113375)
renovate bot
referenced
this pull request
in DelineaXPM/terraform-provider-dsv
Jan 23, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://togithub.com/actions/checkout) | action | major | `v3` -> `v4` | | [crazy-max/ghaction-import-gpg](https://togithub.com/crazy-max/ghaction-import-gpg) | action | major | `v5` -> `v6` | | [goreleaser/goreleaser-action](https://togithub.com/goreleaser/goreleaser-action) | action | major | `v3.2.0` -> `v5.0.0` | | [magefile/mage-action](https://togithub.com/magefile/mage-action) | action | major | `v2` -> `v3` | | [magnetikonline/action-golang-cache](https://togithub.com/magnetikonline/action-golang-cache) | action | major | `v3` -> `v4` | --- ### Release Notes <details> <summary>actions/checkout (actions/checkout)</summary> ### [`v4`](https://togithub.com/actions/checkout/blob/HEAD/CHANGELOG.md#v400) [Compare Source](https://togithub.com/actions/checkout/compare/v3...v4) - [Support fetching without the --progress option](https://togithub.com/actions/checkout/pull/1067) - [Update to node20](https://togithub.com/actions/checkout/pull/1436) </details> <details> <summary>crazy-max/ghaction-import-gpg (crazy-max/ghaction-import-gpg)</summary> ### [`v6`](https://togithub.com/crazy-max/ghaction-import-gpg/compare/v5...v6) [Compare Source](https://togithub.com/crazy-max/ghaction-import-gpg/compare/v5...v6) </details> <details> <summary>goreleaser/goreleaser-action (goreleaser/goreleaser-action)</summary> ### [`v5.0.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v5.0.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.6.0...v5.0.0) #### What's Changed - feat: node 20 as default runtime (requires [Actions Runner v2.308.0](https://togithub.com/actions/runner/releases/tag/v2.308.0) or later) by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/goreleaser/goreleaser-action/pull/432](https://togithub.com/goreleaser/goreleaser-action/pull/432) - chore(deps): bump [@​actions/core](https://togithub.com/actions/core) from 1.10.0 to 1.10.1 in [https://github.com/goreleaser/goreleaser-action/pull/434](https://togithub.com/goreleaser/goreleaser-action/pull/434) **Full Changelog**: goreleaser/goreleaser-action@v4.6.0...v5.0.0 ### [`v4.6.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.6.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.5.0...v4.6.0) Reverts the change to `node20` runtime. **Full Changelog**: goreleaser/goreleaser-action@v4.5.0...v4.6.0 ### [`v4.5.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.5.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.4.0...v4.5.0) #### What's Changed - chore(deps): bump word-wrap from 1.2.3 to 1.2.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/goreleaser/goreleaser-action/pull/427](https://togithub.com/goreleaser/goreleaser-action/pull/427) - feat: bump to use node20 runtime, actions/checkout to v4 by [@​kbdharun](https://togithub.com/kbdharun) in [https://github.com/goreleaser/goreleaser-action/pull/430](https://togithub.com/goreleaser/goreleaser-action/pull/430) #### New Contributors - [@​kbdharun](https://togithub.com/kbdharun) made their first contribution in [https://github.com/goreleaser/goreleaser-action/pull/430](https://togithub.com/goreleaser/goreleaser-action/pull/430) **Full Changelog**: goreleaser/goreleaser-action@v4.4.0...v4.5.0 ### [`v4.4.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.4.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.3.0...v4.4.0) #### What's Changed - chore(deps): bump semver from 7.5.0 to 7.5.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/goreleaser/goreleaser-action/pull/417](https://togithub.com/goreleaser/goreleaser-action/pull/417) - feat: support oss nightlies by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/goreleaser/goreleaser-action/pull/424](https://togithub.com/goreleaser/goreleaser-action/pull/424) **Full Changelog**: goreleaser/goreleaser-action@v4.3.0...v4.4.0 ### [`v4.3.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.3.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.2.0...v4.3.0) #### What's Changed - Update in command examples by [@​arnaduga](https://togithub.com/arnaduga) in [https://github.com/goreleaser/goreleaser-action/pull/393](https://togithub.com/goreleaser/goreleaser-action/pull/393) - chore(deps): bump yargs from 17.6.2 to 17.7.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/goreleaser/goreleaser-action/pull/395](https://togithub.com/goreleaser/goreleaser-action/pull/395) - Improve documentation for use of `GITHUB_TOKEN` by [@​jamietanna](https://togithub.com/jamietanna) in [https://github.com/goreleaser/goreleaser-action/pull/399](https://togithub.com/goreleaser/goreleaser-action/pull/399) - chore(deps): bump actions/setup-go from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/goreleaser/goreleaser-action/pull/403](https://togithub.com/goreleaser/goreleaser-action/pull/403) - chore(deps): bump docker/bake-action from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/goreleaser/goreleaser-action/pull/408](https://togithub.com/goreleaser/goreleaser-action/pull/408) - chore(deps): bump semver from 7.3.8 to 7.5.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/goreleaser/goreleaser-action/pull/407](https://togithub.com/goreleaser/goreleaser-action/pull/407) - Bump setup-go action version to v4 in README by [@​kishaningithub](https://togithub.com/kishaningithub) in [https://github.com/goreleaser/goreleaser-action/pull/411](https://togithub.com/goreleaser/goreleaser-action/pull/411) - ci: split test and validate workflow by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/goreleaser/goreleaser-action/pull/413](https://togithub.com/goreleaser/goreleaser-action/pull/413) - chore: update yarn to 3.5.1 by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/goreleaser/goreleaser-action/pull/412](https://togithub.com/goreleaser/goreleaser-action/pull/412) - chore(deps): bump yargs from 17.7.1 to 17.7.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/goreleaser/goreleaser-action/pull/410](https://togithub.com/goreleaser/goreleaser-action/pull/410) - feat: support nightly by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/goreleaser/goreleaser-action/pull/419](https://togithub.com/goreleaser/goreleaser-action/pull/419) #### New Contributors - [@​arnaduga](https://togithub.com/arnaduga) made their first contribution in [https://github.com/goreleaser/goreleaser-action/pull/393](https://togithub.com/goreleaser/goreleaser-action/pull/393) - [@​jamietanna](https://togithub.com/jamietanna) made their first contribution in [https://github.com/goreleaser/goreleaser-action/pull/399](https://togithub.com/goreleaser/goreleaser-action/pull/399) - [@​kishaningithub](https://togithub.com/kishaningithub) made their first contribution in [https://github.com/goreleaser/goreleaser-action/pull/411](https://togithub.com/goreleaser/goreleaser-action/pull/411) **Full Changelog**: goreleaser/goreleaser-action@v4.2.0...v4.3.0 ### [`v4.2.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.2.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.1.1...v4.2.0) ##### What's Changed - fix: don't depend on the GitHub API to check release by [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/goreleaser/goreleaser-action/pull/391](https://togithub.com/goreleaser/goreleaser-action/pull/391) **Full Changelog**: goreleaser/goreleaser-action@v4.1.1...v4.2.0 ### [`v4.1.1`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.1.1) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.1.0...v4.1.1) ##### What's Changed - Update Readme to reference `goreleaser/goreleaser-action@v4` by [@​felladrin](https://togithub.com/felladrin) in [https://github.com/goreleaser/goreleaser-action/pull/384](https://togithub.com/goreleaser/goreleaser-action/pull/384) - docs: fix README badge by [@​dirien](https://togithub.com/dirien) in [https://github.com/goreleaser/goreleaser-action/pull/386](https://togithub.com/goreleaser/goreleaser-action/pull/386) - chore(deps): bump json5 from 2.2.0 to 2.2.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/goreleaser/goreleaser-action/pull/388](https://togithub.com/goreleaser/goreleaser-action/pull/388) - fix: use [@​action/github](https://togithub.com/action/github) by [@​caarlos0](https://togithub.com/caarlos0) and [@​crazy-max](https://togithub.com/crazy-max) in [https://github.com/goreleaser/goreleaser-action/pull/390](https://togithub.com/goreleaser/goreleaser-action/pull/390) ##### New Contributors - [@​felladrin](https://togithub.com/felladrin) made their first contribution in [https://github.com/goreleaser/goreleaser-action/pull/384](https://togithub.com/goreleaser/goreleaser-action/pull/384) - [@​dirien](https://togithub.com/dirien) made their first contribution in [https://github.com/goreleaser/goreleaser-action/pull/386](https://togithub.com/goreleaser/goreleaser-action/pull/386) **Full Changelog**: goreleaser/goreleaser-action@v4.1.0...v4.1.1 ### [`v4.1.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.1.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v4.0.0...v4.1.0) ##### What's Changed - feat!: remove auto-snapshot on dirty tag by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/goreleaser/goreleaser-action/pull/382](https://togithub.com/goreleaser/goreleaser-action/pull/382) - docs: add example when using workdir along with upload-artifact by [@​zdtsw](https://togithub.com/zdtsw) in [https://github.com/goreleaser/goreleaser-action/pull/366](https://togithub.com/goreleaser/goreleaser-action/pull/366) - Fix Self-Hosted Windows Error: Expand-Archive by [@​flarco](https://togithub.com/flarco) in [https://github.com/goreleaser/goreleaser-action/pull/379](https://togithub.com/goreleaser/goreleaser-action/pull/379) - chore(deps): bump minimatch from 3.0.4 to 3.1.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/goreleaser/goreleaser-action/pull/383](https://togithub.com/goreleaser/goreleaser-action/pull/383) ##### Migrating from v3 If you need the auto-snapshot feature, take a look at [this example repository](https://togithub.com/caarlos0/goreleaser-action-v4-auto-snapshot-example): it's a minimal working example with all you need. ##### New Contributors - [@​zdtsw](https://togithub.com/zdtsw) made their first contribution in [https://github.com/goreleaser/goreleaser-action/pull/366](https://togithub.com/goreleaser/goreleaser-action/pull/366) - [@​flarco](https://togithub.com/flarco) made their first contribution in [https://github.com/goreleaser/goreleaser-action/pull/379](https://togithub.com/goreleaser/goreleaser-action/pull/379) **Full Changelog**: goreleaser/goreleaser-action@v4...v4.1.0 ### [`v4.0.0`](https://togithub.com/goreleaser/goreleaser-action/releases/tag/v4.0.0) [Compare Source](https://togithub.com/goreleaser/goreleaser-action/compare/v3.2.0...v4.0.0) ##### What's Changed - fix: do not override GORELEASER_CURRENT_TAG by [@​caarlos0](https://togithub.com/caarlos0) in [https://github.com/goreleaser/goreleaser-action/pull/370](https://togithub.com/goreleaser/goreleaser-action/pull/370) ##### Migrating from v3 If you need the auto-snapshot feature, take a look at [this example repository](https://togithub.com/caarlos0/goreleaser-action-v4-auto-snapshot-example): it's a minimal working example with all you need. **Full Changelog**: goreleaser/goreleaser-action@v3...v4.0.0 </details> <details> <summary>magefile/mage-action (magefile/mage-action)</summary> ### [`v3`](https://togithub.com/magefile/mage-action/compare/v2...v3) [Compare Source](https://togithub.com/magefile/mage-action/compare/v2...v3) </details> <details> <summary>magnetikonline/action-golang-cache (magnetikonline/action-golang-cache)</summary> ### [`v4`](https://togithub.com/magnetikonline/action-golang-cache/releases/tag/v4) [Compare Source](https://togithub.com/magnetikonline/action-golang-cache/compare/v3...v4) - Provide action outputs of `build-cache-path`, `module-cache-path` and `cache-key`. - Bump `actions/setup-go@v4` - Some `README.md` cleanups. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/DelineaXPM/terraform-provider-dsv). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #380