implemented language tag (please review this first)#115
Open
egandro wants to merge 1 commit intogorilla:mainfrom
Open
implemented language tag (please review this first)#115egandro wants to merge 1 commit intogorilla:mainfrom
egandro wants to merge 1 commit intogorilla:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
language tag is implemented
ISO639Code with simple regex check
^[a-z]{2,3}(-[a-zA-Z0-9-]+)?$This is pragmatic, as ISO639 is fluid with -1, -2, -2 and real world might be sending us any string.
-> Please ping me if we want this test to be:
Added/updated tests?
Run verifications and test
make verifyis passingmake testis passing