Use logger interface in recovery handler (#92) #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping |
|
Looks good to me apart from the name |
ca2fc92 to
3fda98c
Compare
|
Done. |
|
Cool. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I would like to address (#92) and allow the recovery handler to accept interface instead of struct. Existing applications will still work, since the default logger implements this interface (already covered with unit tests).
This will allow developers to pass in a structured logger (e.g. Logrus), which can store some other fields (e.g. host, environment, service name etc.) in the message in addition to the panic. Also many applications log the output in JSON or some other format, which is easier to run queries against.