[compress] Vary: Accept-Encoding must always be set #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elithrar
suggested changes
Jan 5, 2020
Contributor
elithrar
left a comment
There was a problem hiding this comment.
Can you make Accept-Encoding a constant to avoid future regressions? Replace all string literals with that.
Other than that: LGTM.
Contributor
Author
|
@elithrar constant added |
elithrar
approved these changes
Jan 5, 2020
Contributor
|
Thanks! |
Contributor
Author
|
Would it be possible to create a new tag containing this patch? Thank you very much! |
aledbf
added a commit
to gitpod-io/gitpod
that referenced
this pull request
May 14, 2021
Update route tests - gorilla/handlers#175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Vary: Content-Encodingmust always be set, even if the client doesn't support compression, to prevent corruption of intermediate caches such as Varnish.This bug has been reported by @nicolas-grekas while working with Vulcain.rocks. Fun fact: Nicolas reported the exact same bug to PHP... 12 years ago 🙂