fix flate write pool size to work with best compression#208
Merged
2 commits merged intogorilla:masterfrom Jan 24, 2017
FZambia:flate_write_pool_fix
Merged
fix flate write pool size to work with best compression#2082 commits merged intogorilla:masterfrom FZambia:flate_write_pool_fix
2 commits merged intogorilla:masterfrom
FZambia:flate_write_pool_fix
Conversation
|
Thanks for spotting this. There's also an issue with level -2. It's only supported on Go 1.7 and up. |
Contributor
Author
|
Maybe just remove this test then? It actually does not check too much |
|
Yes, remove the test. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently SetCompressionLevel panics:
index out of range.