cmd/govim: refactor file watching #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeee81b to
1cc6d9a
Compare
f22df9c to
227890f
Compare
myitcv
reviewed
Apr 6, 2021
Member
myitcv
left a comment
There was a problem hiding this comment.
I'll have a closer look later, but just a couple of initial questions.
227890f to
d5366e9
Compare
Member
Author
|
Updated per your comments, PTAL when you have time. |
d5366e9 to
dca5475
Compare
myitcv
approved these changes
Apr 11, 2021
Member
myitcv
left a comment
There was a problem hiding this comment.
Some small nits, and one more fundamental questions. But overall, I'm very supportive and grateful for you tidying up this code. It's one of those areas with loads of edge cases. So better to get this in sooner rather than later, and then iterate of further fixes guided by tests.
2cfd4eb to
483d1c7
Compare
The previous file watchers was broken in several ways, where the two major was: * A race condition in the non-darwin watcher (#492) * Darwin recursively watched the entire module directory, disregarding sub-modules, testdata directories and files/dirs prefixed by _ or . This caused the test suite to always fail on macOS. This change: * Moves the non-recursive handling into os_other.go * Adds an OS independent function that filter events specifically disallowed by Go (i.e. "testdata", sub-modules and directories prefixed by _ or . * Adds more tests to raise file watching cover Closes #492
483d1c7 to
eca085c
Compare
Member
|
Still LGTM 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous file watchers was broken in several ways, where the two
major was:
sub-modules, testdata directories and directories prefixed by _ or .
This caused the test suite to always fail on macOS.
This change:
disallowed by Go (i.e. "testdata", sub-modules and directories
prefixed by _ or .
Closes #492