cmd/govim: use span.URI.Filename() when handling filenames #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When interpretting URIs from gopls, we need to use the span.URI.Filename() when we are expecting a filename. This ensures we properly decode the URL, which in turn properly decodes the hex-encoded path elements, like '!', which can appear in module paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When interpretting URIs from gopls, we need to use the
span.URI.Filename() when we are expecting a filename. This ensures we
properly decode the URL, which in turn properly decodes the hex-encoded
path elements, like '!', which can appear in module paths.