Thanks to visit codestin.com
Credit goes to github.com

Skip to content

cmd/govim: test the setting of GoplsEnv with build tags in GOFLAGS #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myitcv merged 1 commit into from
Feb 11, 2020
Merged

cmd/govim: test the setting of GoplsEnv with build tags in GOFLAGS #595

myitcv merged 1 commit into from
Feb 11, 2020

Conversation

@myitcv
Copy link
Member

@myitcv myitcv commented Nov 25, 2019

No description provided.

@myitcv myitcv force-pushed the cmd_govim_gopls_env_config_build_tags branch 3 times, most recently from ba38dcc to c67cd7c Compare December 2, 2019 12:56
@myitcv myitcv force-pushed the cmd_govim_gopls_env_config_build_tags branch from c67cd7c to 63326d3 Compare December 5, 2019 15:01
@myitcv myitcv added the onhold Probably pending some 3rd party issue label Dec 5, 2019
@myitcv myitcv force-pushed the cmd_govim_gopls_env_config_build_tags branch 9 times, most recently from de0fa74 to 5da8ba3 Compare December 13, 2019 15:35
@myitcv myitcv force-pushed the cmd_govim_gopls_env_config_build_tags branch 4 times, most recently from ed80734 to a28b4a6 Compare December 22, 2019 15:43
@myitcv myitcv changed the title [WIP] cmd/govim: test the setting of GoplsEnv with build tags in GOFLAGS cmd/govim: test the setting of GoplsEnv with build tags in GOFLAGS Jan 23, 2020
@myitcv myitcv force-pushed the cmd_govim_gopls_env_config_build_tags branch from a28b4a6 to b565b88 Compare January 23, 2020 00:48
@myitcv myitcv changed the title cmd/govim: test the setting of GoplsEnv with build tags in GOFLAGS [WIP] cmd/govim: test the setting of GoplsEnv with build tags in GOFLAGS Jan 23, 2020
@myitcv myitcv force-pushed the cmd_govim_gopls_env_config_build_tags branch 9 times, most recently from 5112e59 to 4136f0d Compare January 30, 2020 23:41
@myitcv myitcv force-pushed the cmd_govim_gopls_env_config_build_tags branch 2 times, most recently from 5db6c14 to 98299bb Compare February 1, 2020 08:22
@myitcv myitcv force-pushed the cmd_govim_gopls_env_config_build_tags branch from 98299bb to 2042e9c Compare February 10, 2020 14:42
@myitcv myitcv changed the title [WIP] cmd/govim: test the setting of GoplsEnv with build tags in GOFLAGS cmd/govim: test the setting of GoplsEnv with build tags in GOFLAGS Feb 10, 2020
@myitcv myitcv force-pushed the cmd_govim_gopls_env_config_build_tags branch from 2042e9c to b6c0d4d Compare February 10, 2020 14:58
@myitcv myitcv removed the onhold Probably pending some 3rd party issue label Feb 10, 2020
@myitcv myitcv requested a review from leitzler February 10, 2020 19:46
leitzler
leitzler approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, otherwise LGTM

@myitcv
cmd/govim: test the setting of GoplsEnv with build tags in GOFLAGS
b182a61 
We currently support the setting of GOFLAGS with values like
-modefile=go.local.mod. But because of golang.org/issues/29202 have been
unable to supported (in a tested way) the setting of build tags as part
of GOFLAGS.

Add such a test to verify the gopls fix works, but skip for now pending
golang.org/issues/29202.
@myitcv myitcv force-pushed the cmd_govim_gopls_env_config_build_tags branch from b6c0d4d to b182a61 Compare February 11, 2020 05:50
@myitcv myitcv merged commit a300cd4 into master Feb 11, 2020
@myitcv myitcv deleted the cmd_govim_gopls_env_config_build_tags branch February 11, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leitzler leitzler leitzler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@myitcv @leitzler