Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@myitcv
Copy link
Member

@myitcv myitcv commented Nov 25, 2019

No description provided.

@myitcv myitcv requested a review from leitzler November 25, 2019 11:55
@myitcv myitcv force-pushed the cmd_govim_wait_configuration branch 2 times, most recently from 20e41c3 to 3cc9949 Compare November 26, 2019 12:27
Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a tiny note

As a temporary, fragile workaround for

This is a rather fragile workaround for
golang/go#35817, we block the initialisation
of govim until we have received the Configuration call from gopls.  It's
fragile because we are relying on gopls not handling any requests until
the response to Configuration is received and processed. In practice
this appears to currently be the case but there is no guarantee of this
going forward. Rather we hope that a fix for
golang/go#35817 lands sooner rather than later
at whic point this workaround can go.

We also use a lock here because, despite it appearing that will only be a single
Configuration call and that if there were more they would be serial, we can't rely on
this.

This is fragile and best and built on broken assumptions at worst. But
it should suffice for now.
@myitcv myitcv force-pushed the cmd_govim_wait_configuration branch from 3cc9949 to 9ef2a69 Compare November 27, 2019 12:05
@myitcv myitcv merged commit 2db04e5 into master Nov 27, 2019
@myitcv myitcv deleted the cmd_govim_wait_configuration branch November 27, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants