Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@myitcv
Copy link
Member

@myitcv myitcv commented Dec 1, 2019

No description provided.

As described in:

  #603 (comment)

we currently have a situation whereby the home directory sits within the
root directory of a script test. Given that most scripts also put files
in this root directory, i.e. the script root is also the main module
root, we have a situation where files in the home directory are
contained within the main module.

We do not set GOPATH explicitly as part of our tests, hence GOPATH
defaults to being a subdirectory within the home directory, i.e. also
part of the main module.

As we are now using goproxytest, this means modules we access end up
being expanded to $HOME/go/pkg/mod.

The file watcher that is part of govim is somewhat broken (#604) and we
end up watching changes to nested modules in $HOME/go/pkg/mod.

Whilst we have raised #604 in order to fix the file watching problem, we
can also fix this problem in the short term by defining HOME as:

  $script_root/.home

At the same time, we fix a bug in the watcher whereby we were not
correctly skipping hidden directories.

Fixes #603
@myitcv myitcv force-pushed the test_hide_home_dir branch from affa04c to 0ecb48f Compare December 1, 2019 17:07
@myitcv myitcv requested a review from leitzler December 1, 2019 17:14
Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myitcv myitcv merged commit 6f5e25a into master Dec 3, 2019
@myitcv myitcv deleted the test_hide_home_dir branch December 3, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants