cmd/govim: extract text property removal to own func #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
reviewed
Jan 30, 2020
ccfeb82 to
85a6e27
Compare
This change extracts text property removal to it's own func. It acts as gardening for implementing references highlights where we'll start using another text property ID, and therefore it is added as an internal type. A new batch method is also added, BatchStartIfNeeded() that is used to prevent unnecessary round trips to vim when calling a function that might or might not be within a batch scope already.
85a6e27 to
c344c55
Compare
myitcv
approved these changes
Jan 30, 2020
Member
myitcv
left a comment
There was a problem hiding this comment.
LGTM if build passes - we can tidy up batching later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extracts text property removal to it's own func.
It acts as gardening for implementing references highlights where we'll
start using another text property ID, and therefore it is added as an
internal type.