Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci: move to GitHub actions #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myitcv merged 1 commit into from
Jan 30, 2020
Merged

ci: move to GitHub actions #744

myitcv merged 1 commit into from
Jan 30, 2020

Conversation

@myitcv
Copy link
Member

@myitcv myitcv commented Jan 30, 2020

No description provided.

@myitcv myitcv force-pushed the ci_move_to_github_actions branch 16 times, most recently from 2708956 to c41c16e Compare January 30, 2020 19:13
@myitcv
ci: move to GitHub actions
54f380d 
With GitHub actions we can have 20 concurrent jobs. And startup is
faster. It's a no-brainer.

With thanks to @mvdan.

Things that don't (easily) translate:

* being able to set environment variables via the GitHub UI. This means
  that RACE_BUILD is now, in effect, useless because it needs to be set
  in a commit. On top of this it's not possible to re-trigger a build
  from the GitHub UI.
* we don't appear to be able to configure notifications in the build
  config. Only a user can configure what notifications they want to
  receive in their github.com/$USERNAME/notifications page, and those
  config knobs are fairly coarse-grained.

We will convert the config to being CUE-based in a later PR.
@myitcv myitcv force-pushed the ci_move_to_github_actions branch from c41c16e to 54f380d Compare January 30, 2020 19:13
@myitcv myitcv requested a review from leitzler January 30, 2020 19:20
leitzler
leitzler approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myitcv myitcv merged commit 59ef3d6 into master Jan 30, 2020
@myitcv myitcv deleted the ci_move_to_github_actions branch January 30, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leitzler leitzler leitzler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@myitcv @leitzler