Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@leitzler
Copy link
Member

@leitzler leitzler commented Feb 4, 2020

Jobs that are skipped in WIP branches have no $ARTEFACTS directory
so those will fail during post run.

This change adds a branchCheck to exit gracefully.

@myitcv
Copy link
Member

myitcv commented Feb 4, 2020

I think we can probably enhance this somewhat to then skip the uploading of artefacts, but good for now.

Copy link
Member

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leitzler leitzler force-pushed the fix_wip_github_actions branch from cca6bb8 to 5d69a47 Compare February 4, 2020 09:26
Jobs that are skipped in WIP branches have no $ARTEFACTS directory
so those will fail during post run.

This change adds a branchCheck to exit gracefully.
@leitzler leitzler force-pushed the fix_wip_github_actions branch from 5d69a47 to 1811041 Compare February 4, 2020 09:50
@leitzler
Copy link
Member Author

leitzler commented Feb 4, 2020

I think we can probably enhance this somewhat to then skip the uploading of artefacts, but good for now.

Yeah, upload step failed too so I added an exported ENV var. We should probably tidy up the process a bit more, but it would be nice to get things working.

@leitzler leitzler merged commit faf4593 into master Feb 4, 2020
@leitzler leitzler deleted the fix_wip_github_actions branch February 4, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants