cmd/govim: handle nil response to Hover #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current gopls implementation, if there is nothing under the cursor when we call Hover we simply get a zero value protocol.Hover returned (albeit via a pointer variable). As of de023d59a5d1 gopls now returns a zero value of type *protocol.Hover. Hence where we previously assumed we would not get a nil value we now do. Fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current gopls implementation, if there is nothing under the
cursor when we call Hover we simply get a zero value protocol.Hover
returned (albeit via a pointer variable).
As of de023d59a5d1 gopls now returns a zero value of type
*protocol.Hover. Hence where we previously assumed we would not get a
nil value we now do.
Fix that.