cmd/govim: echoerr when user tries to load using a bad version of Vim #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
FYI @ohait |
leitzler
reviewed
Mar 31, 2020
709a93e to
59bc9ea
Compare
Vim v8.2.0452 introduced a bug that affects govim, causing it to hang: https://groups.google.com/forum/#!msg/vim_dev/AjQA8dE0EpY/miFlLh0PAwAJ This bug was fixed in v8.2.0466. Echo an error if the user is found to be using a bad version. Fixes #837
59bc9ea to
38dfa7b
Compare
Member
Author
|
PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vim v8.2.0452 introduced a bug that affects govim, causing it to hang:
https://groups.google.com/forum/#!msg/vim_dev/AjQA8dE0EpY/miFlLh0PAwAJ
This bug was fixed in v8.2.0466.
Echo an error if the user is found to be using a bad version.
Fixes #837