Thanks to visit codestin.com
Credit goes to github.com

Skip to content

cmd/govim: tidy-up refactor #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myitcv merged 1 commit into from
Apr 8, 2020
Merged

cmd/govim: tidy-up refactor #847

myitcv merged 1 commit into from
Apr 8, 2020

Conversation

@myitcv
Copy link
Member

@myitcv myitcv commented Apr 6, 2020

No description provided.

@myitcv myitcv force-pushed the cmd_govim_tidy_refactor branch 3 times, most recently from 52a9d53 to a94d5ef Compare April 7, 2020 16:44
@myitcv myitcv changed the title [DO NOT MERGE] cmd/govim: tidy-up refactor cmd/govim: tidy-up refactor Apr 7, 2020
@myitcv myitcv force-pushed the cmd_govim_tidy_refactor branch from a94d5ef to ac7da12 Compare April 7, 2020 18:11
@myitcv myitcv requested a review from leitzler April 7, 2020 18:12
@myitcv myitcv force-pushed the cmd_govim_tidy_refactor branch from ac7da12 to 6ea46a3 Compare April 7, 2020 18:46
leitzler
leitzler approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myitcv
cmd/govim: tidy-up refactor
2f5fe18 
* move gopls logic into a separate file to keep main.go small
* move flag and core main logic into flag.go
* factor out a method to calculate quickfix entires from
  protocol.Location
@myitcv myitcv force-pushed the cmd_govim_tidy_refactor branch from 6ea46a3 to 2f5fe18 Compare April 8, 2020 23:09
@myitcv myitcv merged commit 8ef9929 into master Apr 8, 2020
@myitcv myitcv deleted the cmd_govim_tidy_refactor branch April 8, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leitzler leitzler leitzler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@myitcv @leitzler