Thanks to visit codestin.com
Credit goes to github.com

Skip to content

cmd/govim/internal/types: refactor into multiple files #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myitcv merged 1 commit into from
Apr 23, 2020
Merged

cmd/govim/internal/types: refactor into multiple files #858

myitcv merged 1 commit into from
Apr 23, 2020

Conversation

@myitcv
Copy link
Member

@myitcv myitcv commented Apr 14, 2020

Makes a bit more sense to have separate files for the major types in
this package that have multiples methods, supporting functions etc

@myitcv
cmd/govim/internal/types: refactor into multiple files
b4fe3b9 
Makes a bit more sense to have separate files for the major types in
this package that have multiples methods, supporting functions etc
@myitcv myitcv requested a review from leitzler April 22, 2020 10:03
leitzler
leitzler approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myitcv myitcv merged commit 1986dfd into master Apr 23, 2020
@myitcv myitcv deleted the cmd_govim_refactor_internal_types branch April 23, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leitzler leitzler leitzler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@myitcv @leitzler