cmd/govim: use gopls serve command explicitly #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the near future, the default zero-command-implied serve behaviour will disappear.
Member
Author
|
@ianthehat does this look good to you? |
ianthehat
approved these changes
Jun 24, 2020
Member
|
We do run into some issues with our @ianthehat how close is "the near future"? I suggest that we revert this one until we have a nice solution for passing flags to |
leitzler
added a commit
that referenced
this pull request
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the near future, the default zero-command-implied serve behaviour
will disappear.