Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@myitcv
Copy link
Member

@myitcv myitcv commented Jul 13, 2020

The Go version numbers used by the setup-go action do not,
unfortunately, following the versioning scheme used by Go itself. Fix
the version used for the Vim master build.

@myitcv myitcv requested a review from leitzler July 13, 2020 15:29
@myitcv
Copy link
Member Author

myitcv commented Jul 13, 2020

For comfort, this was tested in https://github.com/govim/govim/actions/runs/167151873

@myitcv myitcv force-pushed the fix_vim_master_build branch from b042482 to 20942f0 Compare July 13, 2020 17:02
Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the comment about error handling, but since this is just a temporary hack it is mostly nits.

The Go version numbers used by the setup-go action do not,
unfortunately, following the versioning scheme used by Go itself. Fix
the version used for the Vim master build.
@myitcv myitcv force-pushed the fix_vim_master_build branch from 20942f0 to d56bfec Compare July 14, 2020 10:18
@myitcv myitcv merged commit 54eb286 into master Jul 14, 2020
@myitcv myitcv deleted the fix_vim_master_build branch July 14, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants