Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@leitzler
Copy link
Member

@leitzler leitzler commented Jul 16, 2020

  • internal/lsp: add a configuration to enable/disable links in hover 6ddee643
  • internal/lsp: log errors for compute fix edits instead of returning d518495e
  • internal/lsp: refactor go.mod diagnostics to simplify the API 58eba7e7
  • internal/lsp/lsprpc: improvements to daemon logging f2c07d7d
  • internal/lsp/regtest: simpler way to invert options cf799cae
  • internal/lsp: don't keep track of closed overlays 43ed9469
  • internal/lsp: fix error in CL 242457 e66011cb
  • internal/lsp: clean up the code lens code a8f9df4c
  • internal/lsp: refactor generate code lens code c80dc571
  • go/packages: add x test overlay test 130c9f19
  • internal/lsp: add an importShortcut configuration ddb87c8c
  • internal/lsp: handle nil pointer in PackageStats 4cea8971
  • internal/lsp/source: handle nil pointer in newBuiltinSignature b42590c1
  • internal/lsp: avoid panic caused by assuming file ends with newline 9048b464
  • internal/lsp: always show signature as the top line in hover 6acd2ab8
  • gopls, internal/lsp: support an extra formatting hook for gofumpt 62a0bb78
  • internal/lsp: add changeMethods logic to rename check f8240f79
  • internal/lsp/source: add Vendor to list of supported commands 01425d70
  • internal/analysisinternal: do not initialize {Get,Set}TypeErrors f739c553
  • internal/lsp: watch go.{mod,sum} files, as well as Go files fd294ab1
  • internal/lsp/cmd: add a -vv flag for higher verbosity 7342f973
  • internal/lsp, go/packages: reproduce and fix x/tools/gopls: no diagnostics received for initially empty files (sometimes) golang/go#39646 f1c4188a
  • internal/lsp: add new go.mod requires to files with unused require 125cc70a
  • internal/lsp: fix rename with Windows line endings 55a0fde5
  • internal/lsp/regtest: standardize on 20s timeout e327e101
  • internal/lsp/regtest: use a common directory for regtest sandboxes e404ca24
  • internal/lsp/regtest: remove stray short timeout df98bc6d
  • internal/lsp/regtest: add a regtest for x/tools/gopls: invalid errors when using "pkgm" VS Code snippet golang/go#39296 3544e8c9
  • internal/lsp/cache: handle missing mod file 31b9a748
  • internal/lsp: check if analysis enabled in convenience fixes 7370b034
  • internal/lsp/regtest: await IWL before running tests 134513de
  • internal/lsp/source: disable fillstruct by default d5a74533
  • internal/lsp/cache: fix race in RunProcessEnvFunc 065b96d3
  • internal/lsp: extract highlighted selection to variable 9c9572d6
  • internal/imports: require valid options, move LocalPrefix up 416e8f4f
  • internal/lsp/analysis/fillstruct: support anonymous structs 9e0a013e
  • cmd/goyacc: print newlines more consistently b22de682
  • all: update dependencies in go.mod file 682c4542
  • internal/lsp/source: handle nil pointer in comment completions 95bc2bdf

@leitzler
Copy link
Member Author

Failed test looks like a flake, can't remember that I've seen it before.

* internal/lsp: add a configuration to enable/disable links in hover 6ddee643
* internal/lsp: log errors for compute fix edits instead of returning d518495e
* internal/lsp: refactor go.mod diagnostics to simplify the API 58eba7e7
* internal/lsp/lsprpc: improvements to daemon logging f2c07d7d
* internal/lsp/regtest: simpler way to invert options cf799cae
* internal/lsp: don't keep track of closed overlays 43ed9469
* internal/lsp: fix error in CL 242457 e66011cb
* internal/lsp: clean up the code lens code a8f9df4c
* internal/lsp: refactor generate code lens code c80dc571
* go/packages: add x test overlay test 130c9f19
* internal/lsp: add an importShortcut configuration ddb87c8c
* internal/lsp: handle nil pointer in PackageStats 4cea8971
* internal/lsp/source: handle nil pointer in newBuiltinSignature b42590c1
* internal/lsp: avoid panic caused by assuming file ends with newline 9048b464
* internal/lsp: always show signature as the top line in hover 6acd2ab8
* gopls, internal/lsp: support an extra formatting hook for gofumpt 62a0bb78
* internal/lsp: add changeMethods logic to rename check f8240f79
* internal/lsp/source: add Vendor to list of supported commands 01425d70
* internal/analysisinternal: do not initialize {Get,Set}TypeErrors f739c553
* internal/lsp: watch go.{mod,sum} files, as well as Go files fd294ab1
* internal/lsp/cmd: add a -vv flag for higher verbosity 7342f973
* internal/lsp, go/packages: reproduce and fix golang/go#39646 f1c4188a
* internal/lsp: add new go.mod requires to files with unused require 125cc70a
* internal/lsp: fix rename with Windows line endings 55a0fde5
* internal/lsp/regtest: standardize on 20s timeout e327e101
* internal/lsp/regtest: use a common directory for regtest sandboxes e404ca24
* internal/lsp/regtest: remove stray short timeout df98bc6d
* internal/lsp/regtest: add a regtest for golang/go#39296 3544e8c9
* internal/lsp/cache: handle missing mod file 31b9a748
* internal/lsp: check if analysis enabled in convenience fixes 7370b034
* internal/lsp/regtest: await IWL before running tests 134513de
* internal/lsp/source: disable fillstruct by default d5a74533
* internal/lsp/cache: fix race in RunProcessEnvFunc 065b96d3
* internal/lsp: extract highlighted selection to variable 9c9572d6
* internal/imports: require valid options, move LocalPrefix up 416e8f4f
* internal/lsp/analysis/fillstruct: support anonymous structs 9e0a013e
* cmd/goyacc: print newlines more consistently b22de682
* all: update dependencies in go.mod file 682c4542
* internal/lsp/source: handle nil pointer in comment completions 95bc2bdf
@leitzler leitzler force-pushed the deps_tools_f2c07d7d branch from 140f512 to 14b22dd Compare July 17, 2020 09:49
@leitzler leitzler changed the title deps: update x/tools and gopls to f2c07d7d deps: update x/tools and gopls to 6ddee643 Jul 17, 2020
@leitzler leitzler requested a review from myitcv July 17, 2020 10:31
Copy link
Member

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for persevering with this

@leitzler leitzler merged commit beba233 into master Jul 17, 2020
@leitzler leitzler deleted the deps_tools_f2c07d7d branch July 17, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/tools/gopls: no diagnostics received for initially empty files (sometimes)

3 participants