Thanks to visit codestin.com
Credit goes to github.com

Skip to content

cmd/govim: drop test skip based on golang.org/issues/36743 #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myitcv merged 1 commit into from
Jul 31, 2020
Merged

cmd/govim: drop test skip based on golang.org/issues/36743 #916

myitcv merged 1 commit into from
Jul 31, 2020

Conversation

@myitcv
Copy link
Member

@myitcv myitcv commented Jul 31, 2020

golang.org/issues/36743 has now been resolved. It appears therefore that
we can re-enable this part of the scenario_default/rename test.

@myitcv
cmd/govim: drop test skip based on golang.org/issues/36743
3929ae3 
golang.org/issues/36743 has now been resolved. It appears therefore that
we can re-enable this part of the scenario_default/rename test.
@myitcv myitcv requested a review from leitzler July 31, 2020 14:22
leitzler
leitzler approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myitcv myitcv merged commit cbf66e7 into main Jul 31, 2020
@myitcv myitcv deleted the drop_skip_of_golang.org_issues_36743 branch July 31, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leitzler leitzler leitzler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@myitcv @leitzler