Thanks to visit codestin.com
Credit goes to github.com

Skip to content

cmd/govim: change test skip to be based on golang.org/issues/36880 #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
myitcv merged 1 commit into from
Jul 31, 2020
Merged

cmd/govim: change test skip to be based on golang.org/issues/36880 #919

myitcv merged 1 commit into from
Jul 31, 2020

Conversation

@myitcv
Copy link
Member

@myitcv myitcv commented Jul 31, 2020 •
edited
Loading

No description provided.

@myitcv myitcv requested a review from leitzler July 31, 2020 14:24
leitzler
leitzler approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myitcv myitcv force-pushed the drop_skip_of_golang.org_issues_37164 branch from d63bf19 to ceb8de0 Compare July 31, 2020 15:11
@myitcv
Copy link
Member Author

myitcv commented Jul 31, 2020

Turns out we can't remove the skip just yet; we got a flake. However it looks like the skip should now be a function of golang/go#36880 based on golang/go#37164 (comment). Will update the URL and merge.

@myitcv
cmd/govim: change test skip to be based on golang.org/issues/36880
a4fe206 
golang.org/issues/37164 has now been closed and the outstanding issues
described in:

golang/go#37164 (comment)

have been transferred to golang.org/issues/36880.

Update the skip for the scenario_bugs/bug_gopls_37164 test to reference
golang.org/issues/36880 therefore.
@myitcv myitcv force-pushed the drop_skip_of_golang.org_issues_37164 branch from ceb8de0 to a4fe206 Compare July 31, 2020 15:35
@myitcv myitcv changed the title cmd/govim: drop test skip based on golang.org/issues/37164 cmd/govim: change test skip to be based on golang.org/issues/36880 Jul 31, 2020
@myitcv myitcv merged commit a26a3bf into main Jul 31, 2020
@myitcv myitcv deleted the drop_skip_of_golang.org_issues_37164 branch July 31, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leitzler leitzler leitzler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@myitcv @leitzler