cmd/govim: add support for popups showing WorkDoneProgress #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab28a1c to
38bc570
Compare
myitcv
approved these changes
Sep 9, 2020
Member
myitcv
left a comment
There was a problem hiding this comment.
LGTM with a couple of comments/questions.
Add experimental support for popups showing WorkDoneProgress.
The feature is disabled by default, and can be enabled via .vimrc:
call govim#config#Set("ExperimentalProgressPopups", 1)
When enabled govim will create notification style popups in
the upper right corner when gopls report progress of a task
(e.g. initial workspace load, running tests or "go generate").
The popup will close itself afterwards.
Note that this is an experimental feature. It has rather limited
use initially since govim doesn't yet support running tests via
gopls for example.
38bc570 to
4a9f30e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add experimental support for popups showing WorkDoneProgress.
The feature is disabled by default, and can be enabled via .vimrc:
call govim#config#Set("ExperimentalProgressPopups", 1)When enabled govim will create notification style popups in
the upper right corner when gopls report progress of a task
(e.g. initial workspace load, running tests or "go generate").
The popup will close itself afterwards.
Note that this is an experimental feature. It has rather limited
use initially since govim doesn't yet support running tests via
gopls for example.