cmd/govim: support multi-line progress messages in popup #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress messages do sometimes contain newlines. To ensure that the popup is rendered correct the progress message is now divided into multiple lines.
myitcv
approved these changes
Oct 8, 2020
Member
myitcv
left a comment
There was a problem hiding this comment.
LGTM with one question: can we add a test for this? i.e. is there a way we can trigger a progress message that we know will be multiline? I guess testing for the existence of that popup is hard...
Member
Author
|
It is tricky with the UI indeed. There aren't any multiline progress messages at the moment, as this is a gardening change for "go test" for example. It has been tested manually at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress messages do sometimes contain newlines. To ensure that the
popup is rendered correct the progress message is now divided into
multiple lines.