Allow splitting translations #52
Conversation
I guess you could say this is a "prototype"
|
I'll try to review this tonight |
Changed `NestedTranslation` from `type` to `interface`.
|
@KnorpelSenf I've changed the |
There was a problem hiding this comment.
The docs of it are in a good shape already!
I quickly glanced over the code but @KnorpelSenf looked into that far more deeply than I did. So I cant say much about it.
|
Thanks for merging the pull-request, are there any details on when the new version will be released? |
|
@rojvv said he wanted to do it “later” … I believe that means it'll happen today at some point. If that doesn't happen, feel free to ping me again |
|
Alright, no worries if it takes a couple of days. |
|
Available in 1.1.0. |
|
Apologies if I'm misunderstanding something, but was this version released correctly? I just tried to upgrade and I got a lot of errors. I looked at the source on NPM and saw that there is no |
|
Apologies for the inconvenience. 1.1.2 should work. |
|
Works as expected, thanks! |
Closes #51
As explained in the issue referenced above, sometimes it becomes too difficult to maintain translation files for a project and currently the library does not allow files to be split into different directories or files.
This pull-request implements this feature by walking every
.ftlfile in the locales directory, reading it, and merging it with any other translation it finds for that locale. This might not be the best way of implementing this feature... but it works. It also works with the standard translation layout currently implemented, which means users can use both types of layouts at once.As of writing this, I haven't discovered anything that would be broken by this pull-request, please do let me know if it does in fact cause breaking changes or if any issues were discovered.