chore: make context flavor transformative #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: I18nFlavor now needs to be used as I18nFlavor<Context>
KnorpelSenf
reviewed
Mar 31, 2025
| type MyContext = | ||
| & Context | ||
| & I18nFlavor | ||
| & I18nFlavor<Context> |
There was a problem hiding this comment.
Those aren't correctly combined
KnorpelSenf
reviewed
Mar 31, 2025
| type MyContext = | ||
| & Context | ||
| & I18nFlavor | ||
| & I18nFlavor<Context> |
KnorpelSenf
reviewed
Mar 31, 2025
| ctx: C, | ||
| ): ctx is HearsContext<C> { | ||
| export function hears<C extends Context>(key: string) { | ||
| return function <TContext extends I18nFlavor<C>>( |
There was a problem hiding this comment.
I wonder if this is better than removing the type parameter from hears and then doing
Suggested change
| return function <TContext extends I18nFlavor<C>>( | |
| return function <C extends Context, CTContext extends I18nFlavor<C>>( |
|
I don't think you should target main just yet |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to grammyjs/grammY#709