Reduce arenamanager allocations#73
Reduce arenamanager allocations#73mangalaman93 merged 7 commits intograndecola:mainfrom moredure:patch-1
Conversation
Codecov Report
@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage ? 79.60%
=======================================
Files ? 10
Lines ? 402
Branches ? 0
=======================================
Hits ? 320
Misses ? 42
Partials ? 40 Continue to review full report at Codecov.
|
mangalaman93
left a comment
There was a problem hiding this comment.
This looks good. Just one comment, thanks for the benchmark. It would be fine to have the benchmark in the repo too. No big deal.
|
Code Climate has analyzed commit 9fac3db and detected 0 issues on this pull request. View more on Code Climate. |
|
Waiting for build to pass before we can merge it. Could be related to #78. |
Reduce memory allocation with same path behaiviour, clean dir once instead of doing it each time.
As an alternative we can do
but it's slightly slower
@mangalaman93, @ashish-goswami please take a look!