[pdc-agent] Expose token secret key name in values#4018
Open
holgerjh wants to merge 3 commits intografana:mainfrom
Open
[pdc-agent] Expose token secret key name in values#4018holgerjh wants to merge 3 commits intografana:mainfrom
holgerjh wants to merge 3 commits intografana:mainfrom
Conversation
Author
|
Fixes #4019 |
dafydd-t
requested changes
Dec 4, 2025
Contributor
dafydd-t
left a comment
There was a problem hiding this comment.
Thanks for the PR!
- Can you bump the chart version please?
- After a merge / rebase & a reorder of
tokenSecretKey&tokenSecretNamein the README (the linting errors), I think we are good to go 👍
Signed-off-by: Holger Johannes Heinz <[email protected]>
86fb96d to
3d243a2
Compare
Author
|
Thanks for your review. As per semantic version, I bumped the minor version as a new field was added to the API (values.yaml) without breaking backward compatibility. Hope that is ok. |
Contributor
This is a newish chart and so we haven't followed semver convention yet, but we may as well start now :) Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the key
tokenSecretKeyto thevalues.yaml. It defines the lookup key used in the token secret defined bytokenSecretNameand allows for a more dynamic configuration.