Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CI: Move browser tests into its own test workflow #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AgnesToulet wants to merge 4 commits into
base: master
Choose a base branch
from
Open

CI: Move browser tests into its own test workflow #5570

AgnesToulet wants to merge 4 commits into from
+225 −83

Conversation

@AgnesToulet
Copy link
Contributor

@AgnesToulet AgnesToulet commented Jan 19, 2026 •
edited
Loading

What?

This PR:

  • Splits the tests into two workflows: one running all tests except for the ones in browser/tests, the other running only browser tests
  • Increases the size of the GH runners for Windows and Ubuntu 24.04 (switch to a self-hosted runner for this one) for the browser tests
  • Stop running the tests concurrently on all OS for browser tests

Why?

Browser tests are too flaky without this configuration.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing January 19, 2026 15:39 — with GitHub Actions Inactive
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing January 19, 2026 15:41 — with GitHub Actions Inactive
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 20, 2026
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing January 20, 2026 15:20 — with GitHub Actions Inactive
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 20, 2026
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing January 20, 2026 15:28 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

Sign in to view
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing January 20, 2026 15:35 — with GitHub Actions Inactive
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing January 20, 2026 15:37 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

Sign in to view
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 20, 2026
View reviewed changes
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing January 20, 2026 16:07 — with GitHub Actions Inactive
@AgnesToulet AgnesToulet force-pushed the ci/split-tests-browser branch from 8169cd4 to 203481a Compare January 20, 2026 16:08
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing January 20, 2026 16:13 — with GitHub Actions Inactive
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing January 20, 2026 16:15 — with GitHub Actions Inactive
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing January 20, 2026 16:22 — with GitHub Actions Inactive
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing January 20, 2026 16:24 — with GitHub Actions Inactive
@AgnesToulet AgnesToulet marked this pull request as ready for review January 20, 2026 17:34
@AgnesToulet AgnesToulet requested a review from a team as a code owner January 20, 2026 17:34
@AgnesToulet AgnesToulet requested review from ankur22 and inancgumus and removed request for a team January 20, 2026 17:34
@AgnesToulet AgnesToulet added this to the v1.6.0 milestone Jan 20, 2026
@AgnesToulet AgnesToulet mentioned this pull request Jan 20, 2026
Open
8 tasks
@AgnesToulet AgnesToulet requested a review from mstoykov January 20, 2026 17:37
AgnesToulet
AgnesToulet commented Jan 20, 2026
View reviewed changes
.github/actions/test-browser/action.yml
Comment on lines +20 to +24
if [[ ${USE_GOTIP} == 'true' ]]; then
export GOROOT="$HOME/sdk/gotip"
export GOPATH="$HOME/go"
export PATH="$HOME/sdk/gotip/bin:$HOME/go/bin:$PATH" > /dev/null
fi
Copy link
Contributor Author

@AgnesToulet AgnesToulet Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to move this here because the following lines were triggering zizmor issues when written in an action:

          echo "GOROOT=$HOME/sdk/gotip" >> "$GITHUB_ENV"
          echo "GOPATH=$HOME/go" >> "$GITHUB_ENV"
          echo "$HOME/go/bin" >> "$GITHUB_PATH"
          echo "$HOME/sdk/gotip/bin" >> "$GITHUB_PATH"

@AgnesToulet AgnesToulet force-pushed the ci/split-tests-browser branch from 6c204de to 23291ca Compare January 22, 2026 09:27
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing January 22, 2026 09:33 — with GitHub Actions Inactive
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing January 22, 2026 09:35 — with GitHub Actions Inactive
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing January 22, 2026 09:44 — with GitHub Actions Inactive
@AgnesToulet AgnesToulet temporarily deployed to azure-trusted-signing January 22, 2026 09:46 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inancgumus inancgumus Awaiting requested review from inancgumus inancgumus is a code owner automatically assigned from grafana/k6-core

@ankur22 ankur22 Awaiting requested review from ankur22 ankur22 is a code owner automatically assigned from grafana/k6-core

@mstoykov mstoykov Awaiting requested review from mstoykov

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

ci tests

Projects

None yet

Milestone

v1.6.0

Development

Successfully merging this pull request may close these issues.

1 participant

@AgnesToulet