feat: default loki-mixin dashboards to TSDB #18732
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR defaults Loki mixin dashboards to use TSDB, which is now the preferred index format. It adds a configuration variable to easily toggle between TSDB and BoltDB dashboards, and includes TSDB shipper monitoring metrics that were previously missing.
Which issue(s) this PR fixes:
Fixes #9772
Special notes for your reviewer:
tsdbconfig variable inconfig.libsonnetdefaults totrue, making TSDB the defaulttsdb: true, BoltDB Shipper panels are hidden and TSDB Shipper panels are shownloki_tsdb_shipper_request_duration_secondsfor monitoring TSDB shipper performanceChecklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PRTested
Tested the dashboard toggle functionality based on tsdb configuration!
After running
make loki-mixin, tested in local Grafana: