Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@hoangthanh28
Copy link
Collaborator

This PR intends to fix issue #591 by changing the bootstrap script to nvarchar(max) instead of text for SQL server.

@wokket
Copy link
Collaborator

wokket commented Oct 1, 2025

This generally looks ok me, nice thinking on the WOOTSC flag 👍

My only real concern is whether these 'By Design' warnings are going to flow into users screens/logs and confuse them?

While I'd love to have some automated tests for this to know how it will actually behave I appreciate that's going to be hard.

I'll endeavour to get some testing done sometime, but the more people can manually run this against some databases (in lieu of automated tests) the happier I'll be about creating my first grate release.

@hoangthanh28
Copy link
Collaborator Author

Hi @wokket
Just find another way (safer) to fix the issue. Please share your thoughts.

Thanks.

@wokket
Copy link
Collaborator

wokket commented Oct 11, 2025

I think I like that solution, nice work 👍

I've had zero time for testing and am unlikely to get anything done for at least another week so anyone else that can review or test would be fantastic.

@hoangthanh28
Copy link
Collaborator Author

I did a lot of testing in regard current version of grate (v1.8), it's all looking good to me. You can merge without any concerns, mate.

All the code has been tested with a real database (in Docker). :D

Thanks.

@tracker1
Copy link
Contributor

Bump

@tracker1
Copy link
Contributor

Tested against my existing and fresh databases and working without issue now.

@wokket
Copy link
Collaborator

wokket commented Oct 28, 2025

Thank you @tracker1 for confirming the testing, and @hoangthanh28 for the change. Merging 🥳

@wokket wokket merged commit c08da10 into grate-devs:main Oct 28, 2025
33 checks passed
@hoangthanh28 hoangthanh28 deleted the hotfixes/utf-8-text-removal branch October 30, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants