Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@daniele-mng
Copy link
Contributor

@daniele-mng daniele-mng commented Oct 24, 2025

What

  • Add feature credential stores

Why

References

GEA-1313

Checklist

  • Tests

@github-actions
Copy link

github-actions bot commented Oct 24, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 1c005f3.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 48.16754% with 495 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.90%. Comparing base (2a2cc87) to head (1c005f3).

Files with missing lines Patch % Lines
...web/pages/credential-store/CredentialStorePage.tsx 0.45% 220 Missing ⚠️
...b/pages/credential-store/CredentialStoreDialog.tsx 0.80% 124 Missing ⚠️
src/gmp/commands/credential-store.ts 21.21% 52 Missing ⚠️
src/web/hooks/use-query/credential-store.ts 2.77% 35 Missing ⚠️
src/web/pages/credentials/Details.jsx 65.07% 22 Missing ⚠️
src/web/pages/credentials/CredentialDialog.tsx 61.11% 14 Missing ⚠️
src/web/pages/targets/TargetDialog.tsx 92.13% 7 Missing ⚠️
src/gmp/models/credential.ts 91.22% 5 Missing ⚠️
src/web/components/menu/Menu.tsx 50.00% 5 Missing ⚠️
src/web/pages/targets/Row.jsx 37.50% 5 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4907      +/-   ##
==========================================
- Coverage   69.10%   68.90%   -0.20%     
==========================================
  Files        1137     1144       +7     
  Lines      105402   106316     +914     
  Branches     8037     8097      +60     
==========================================
+ Hits        72839    73259     +420     
- Misses      32522    33016     +494     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daniele-mng daniele-mng force-pushed the GEA-1313 branch 5 times, most recently from 17607ad to 8fb39eb Compare October 27, 2025 10:55
@daniele-mng daniele-mng marked this pull request as ready for review October 27, 2025 16:30
@daniele-mng daniele-mng requested a review from a team as a code owner October 27, 2025 16:30
@greenbonebot greenbonebot enabled auto-merge (rebase) October 28, 2025 12:55
@daniele-mng daniele-mng force-pushed the GEA-1313 branch 12 times, most recently from 98be75f to b0a440c Compare October 31, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants