Update group_recorder for deltamode interval 0, -1 #1388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed it so interval -1 works with both deltamode AND QSTS (just didn't work)
trevorhardy
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this Pull Request do?
Makes it so interval 0 and interval -1 works with group_recorder in deltamode.
Also put a fix in so -1 works in QSTS too (apparently was broken).
Where should the reviewer start?
See the attached file (generator autotest). The
group_recorderis on the bottom if you want to try different intervals.test_deltamode_diesel_dg.glm.txt
How should this be tested?
Make sure nothings fails, and try the file uploaded (but again, has to be in generators/autotest/subfolder)
Any background context you want to provide?
N/A
What are the relevant issues?
#1354
Screenshots (if appropriate)
N/A
Questions: