Merge of Portland State HPWH model #1389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ftuffner, I'm getting an error on that autotest: |
|
I should note that I'm testing on my Mac using clang but I did do a clean build. |
|
Passes on Windows, but fails in two different spots on Linux and Mac. |
…me system - just committing the assert (and not updating the GLM) apparently doesn't fix it. Understandable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this Pull Request do?
Merges in the updated/functional heat pump water heater model submitted by Portland State/Midrar Adham.
Where should the reviewer start?
Pull, compile, examine the outputs of the new
test_heatpump_waterheater.glmHow should this be tested?
Verify the new water heater model has reasonable temperature regulation (no more going massively out of bounds).
Any background context you want to provide?
What are the relevant issues?
#1123
Screenshots (if appropriate)
N/A
Questions: