Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@korikuzma
Copy link
Collaborator

This is essentially the same as #127 , but excludes molecular profiles. I added some additional fields to the GraphQL queries since we needed this information in MetaKB.

@susannasiebert and @acoffman , once this gets merged would we be able to create a new pypi dev release that we can use in MetaKB?

@susannasiebert
Copy link
Collaborator

I think this looks fine. We need to setup a github action to actually run the tests on github.

In regards to a release, I'm going to be on vacation starting tomorrow and I'm at a conference today so I don't think I can make this release until after I return in three weeks. I also checked on pypi and it looks like I don't have enough permissions to add another maintainer. I think Alex would need to add either yourself or Adam as a maintainer so that you can make a new release if you need it sooner.

@korikuzma
Copy link
Collaborator Author

@susannasiebert I can make a separate issue for the GitHub action.

@ahwagner would you be able to add either @acoffman or I as a maintainer? I'd like to get a dev release sooner that when @susannasiebert returns, if possible.

@korikuzma
Copy link
Collaborator Author

Forgot to update version. Set it to 2.0.dev0. Let me know if it should be something else @susannasiebert or @acoffman

Copy link
Member

@acoffman acoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korikuzma korikuzma removed the request for review from susannasiebert September 21, 2022 14:18
@korikuzma korikuzma merged commit 0e75b30 into master Sep 23, 2022
@korikuzma korikuzma deleted the civic_v2_metakb branch September 23, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants