Added ability to disable writing events to disk with -persist-events flag #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default value set to true
updated the flPersistEvents default value to true and fixed the description text
Added flPersistEvents flag to disable writing events to disk
| -event-logfile string | ||
| path to file for saving uploaded events (default "/tmp/santa_events") | ||
| -persist-events | ||
| Enable writing events to disk (default `true`) |
Contributor
There was a problem hiding this comment.
The PR description says the default value is set to false but it's true here. I think leaving the default set to true makes sense and ensures we won't break others when they upgrade.
Contributor
Author
There was a problem hiding this comment.
Sorry about that, I forgot to change the PR description. I agree with you on setting the default to true.
Do you feel that -persist-events is descriptive enough? I did struggle with finding a suitable name for the flag, this was the best I could come up with.
Collaborator
There was a problem hiding this comment.
Yeah, I think it's fine. Easy change later if needed!
brandonfriess-stripe
approved these changes
Mar 6, 2024
Contributor
|
Thanks for adding! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces a flag, -persist-events, to moroz to addresses the issue of high directory creation and possible inode shortage in some cases along with increased memory usage.
Changes:
Added flPersistEvents field to SantaService struct in moroz/service.go.
Updated all references to SantaService to include the new flPersistEvents field.
Modified related functions and methods to accommodate the new flPersistEvents field.
Impact:
This change allows us to control whether events should be persisted, providing more flexibility for the user. The default value is set to true.
Testing:
Tested locally and successfully stopped writing to disk by when set to false.
./moroz -configs="./configs" -event-dir="./logs" -persist-events="false"