docs: api/grn_db: move grn_db_recover() reference to the header file #1985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub: groongaGH-1817 Prepare to switch to documents automatically generated by Doxygen.
abetomo
commented
Oct 7, 2024
| * \brief Checks the passed database and recovers it if it is broken and it | ||
| * can be recovered. | ||
| * | ||
| * This API uses lock existence for checking whether the database is |
There was a problem hiding this comment.
\details は書かなくても良いっぽいので、省略してみたのだけれど、明記したほうが良いだろうか。
kou
reviewed
Oct 7, 2024
include/groonga/db.h
Outdated
Comment on lines
64
to
65
| * Table and data column can be recovered by removing an existence | ||
| * lock and re-add data. |
There was a problem hiding this comment.
Suggested change
| * Table and data column can be recovered by removing an existence | |
| * lock and re-add data. | |
| * Table and data column can be recovered manually by removing an existence | |
| * lock and re-add data. |
otegami
reviewed
Oct 7, 2024
include/groonga/db.h
Outdated
| GRN_API void | ||
| grn_db_touch(grn_ctx *ctx, grn_obj *db); | ||
| /** | ||
| * \brief Checks the passed database and recovers it if it is broken and it |
There was a problem hiding this comment.
[nits] 三単現のsがないほうが多いので合わせてあげられると良さそうです。
Suggested change
| * \brief Checks the passed database and recovers it if it is broken and it | |
| * \brief Check the passed database and recover it if it is broken and it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: GH-1817
Prepare to switch to documents automatically generated by Doxygen.