Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FEAT] Add websocket transport support #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

[FEAT] Add websocket transport support #73

merged 1 commit into from
Oct 9, 2025

Conversation

@ILJICH
Copy link
Contributor

@ILJICH ILJICH commented Oct 2, 2025

I'm trying to use this lib in a project that uses ws as a main transport for mcp servers. I had to patch it, but here's also a PR that does it properly.
Should work both with ws and wss:

from mcpadapt.core import MCPAdapt
from mcpadapt.smolagents_adapter import SmolAgentsAdapter

with MCPAdapt(
    {"url": "ws://127.0.0.1:8001/ws", "transport": "ws"},
    SmolAgentsAdapter(),
) as tools:
    ...

@ILJICH
Copy link
Contributor Author

ILJICH commented Oct 3, 2025

@grll Hey there, can you take a look at this PR? It'll make my life a little easier ^^

@grll
Copy link
Owner

grll commented Oct 3, 2025

Hey hey thanks for the contribution will have a look soon

@ILJICH
Copy link
Contributor Author

ILJICH commented Oct 9, 2025

@grll Hi, just a friendly reminder that this PR is still waiting for your attention =]
It's basically a one-liner and some tests, shouldn't take much time.

@grll
Copy link
Owner

grll commented Oct 9, 2025

@grll Hi, just a friendly reminder that this PR is still waiting for your attention =] It's basically a one-liner and some tests, shouldn't take much time.

sorry for the delay and thank you for the reminder. The change look good to me! I was a bit surprised that there is no easier way to define a simple echo server with the websocket transport but I guess they are prioritizing other transports...

@grll grll merged commit 70a40f9 into grll:main Oct 9, 2025
3 checks passed
@grll
Copy link
Owner

grll commented Oct 9, 2025

@ILJICH your change is available from v0.1.17 and above:
https://github.com/grll/mcpadapt/releases/tag/v0.1.17

@ILJICH
Copy link
Contributor Author

ILJICH commented Oct 9, 2025

Thank you so much ^^
Yeah, ws is not standard (yet), so not all the libraries support it

@Edison-A-N Edison-A-N mentioned this pull request Oct 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ILJICH @grll