Improve error type with RpcError & internal code sync#1139
Merged
sampajano merged 1 commit intogrpc:masterfrom Sep 22, 2021
Merged
Improve error type with RpcError & internal code sync#1139sampajano merged 1 commit intogrpc:masterfrom
RpcError & internal code sync#1139sampajano merged 1 commit intogrpc:masterfrom
Conversation
stanley-cheung
previously approved these changes
Sep 22, 2021
Collaborator
stanley-cheung
left a comment
There was a problem hiding this comment.
Yay! Finally we are able to do the sync!
Up to Aug 4, 2021 for now.. :) - Also updated Closure dependency to `20210808.0.0` (necessary for tests to pass)
32d4aea to
504c42f
Compare
stanley-cheung
approved these changes
Sep 22, 2021
RpcError and internal code sync
RpcError and internal code syncRpcError & internal code sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
20210808.0.0(necessary dependency)Main code changes:
RpcErrorin favor of untypedError(Thanks @TomiBelan! 😃)StatusCodeto be a enum (not full enum support (e.g.RpcError[RpcError.OK] === 'OK') is there but general===comparison should work)AbstractClientBase.MethodInfoOther changes:
TODO: