Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Fix duplicate dot in enum name (when "package" is specified)#1286

Merged
sampajano merged 1 commit intogrpc:masterfrom
sampajano:1.fix.duplicate.dot
Sep 27, 2022
Merged

Fix duplicate dot in enum name (when "package" is specified)#1286
sampajano merged 1 commit intogrpc:masterfrom
sampajano:1.fix.duplicate.dot

Conversation

@sampajano
Copy link
Collaborator

@sampajano sampajano commented Sep 26, 2022

Summary

Changes

  • This fix makes StripPrefixString remove the leading dot when stripping out a prefix -- and hence will work in both cases (with and without package).
  • Also removed a few now redundant logic to remove leading dots.

Tested

Fixes #1284

@sampajano sampajano changed the title Fix duplicate dot in enum name Fix duplicate dot in enum name (when "package" is specified) Sep 26, 2022
Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sampajano sampajano merged commit 8a12309 into grpc:master Sep 27, 2022
@sampajano sampajano deleted the 1.fix.duplicate.dot branch September 27, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate dot after enum's namespace in typescript file when using dot in package name

2 participants