Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add test under ruby GC stress mode and fix non-GC-rooted variable #12842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2017
Merged

Add test under ruby GC stress mode and fix non-GC-rooted variable #12842

merged 1 commit into from
Oct 5, 2017

Conversation

@apolcyn
Copy link
Contributor

@apolcyn apolcyn commented Oct 5, 2017

Running under GC.stress = 0x04 is slow (this test takes 20-30 seconds), but it's able to catch the bug like the one fixed in this pr.

Fixes issue mentioned in this comment in a protobuf issue.

@apolcyn apolcyn requested a review from murgatroid99 October 5, 2017 16:45
@grpc-testing
Copy link

grpc-testing commented Oct 5, 2017 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@apolcyn apolcyn mentioned this pull request Oct 5, 2017
Merged
@grpc-testing
Copy link

grpc-testing commented Oct 5, 2017 

[trickle] No significant performance differences

@grpc-testing
Copy link

grpc-testing commented Oct 5, 2017 

[microbenchmarks] No significant performance differences

This was referenced Oct 5, 2017
Closed
Closed
@apolcyn
Copy link
Contributor Author

apolcyn commented Oct 5, 2017

test failures:

@apolcyn apolcyn merged commit 998c30d into grpc:master Oct 5, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@murgatroid99 murgatroid99 murgatroid99 approved these changes

Assignees

@murgatroid99 murgatroid99

Labels

cla: yes lang/ruby

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@apolcyn @grpc-testing @murgatroid99 @googlebot