Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump v1.8.0-pre2 to v1.8.0 #13731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2017
Merged

Bump v1.8.0-pre2 to v1.8.0 #13731

merged 1 commit into from
Dec 13, 2017

Conversation

@mehrdada
Copy link
Contributor

@mehrdada mehrdada commented Dec 12, 2017

No description provided.

@mehrdada mehrdada requested a review from dgquintas December 12, 2017 21:46
@grpc-testing
Copy link

grpc-testing commented Dec 12, 2017 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                    FILE SIZE
 ++++++++++++++ GROWING                      ++++++++++++++

 -------------- SHRINKING                    --------------
 -13.0%     -12 src/cpp/common/version_cc.cc     -12 -13.0%
     -26.1%     -12 grpc::Version[abi:cxx11]         -12 -26.1%

 -+-+-+-+-+-+-+ MIXED                        +-+-+-+-+-+-+-
  +0.0%     +12 [None]                           -84  -0.0%

  [ = ]       0 TOTAL                            -96  -0.0%

@jtattermusch
Copy link
Contributor

jtattermusch commented Dec 12, 2017

I think you need to update versions in BUILD file as well?

@mehrdada
Copy link
Contributor Author

mehrdada commented Dec 12, 2017

@jtattermusch doesn't generate_projects do it? I simply invoked that.

@grpc-testing
Copy link

grpc-testing commented Dec 12, 2017 

[trickle] No significant performance differences

@grpc-testing
Copy link

grpc-testing commented Dec 12, 2017 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                    FILE SIZE
 ++++++++++++++ GROWING                      ++++++++++++++

 -------------- SHRINKING                    --------------
 -13.0%     -12 src/cpp/common/version_cc.cc     -12 -13.0%
     -26.1%     -12 grpc::Version[abi:cxx11]         -12 -26.1%

 -+-+-+-+-+-+-+ MIXED                        +-+-+-+-+-+-+-
  +0.0%     +12 [None]                           -84  -0.0%

  [ = ]       0 TOTAL                            -96  -0.0%

@grpc-testing
Copy link

grpc-testing commented Dec 12, 2017 

[trickle] No significant performance differences

@grpc-testing
Copy link

grpc-testing commented Dec 12, 2017 

[microbenchmarks] No significant performance differences

1 similar comment
@grpc-testing
Copy link

grpc-testing commented Dec 12, 2017 

[microbenchmarks] No significant performance differences

@mehrdada mehrdada merged commit ada05af into grpc:v1.8.x Dec 13, 2017
@mehrdada mehrdada deleted the bump-v1.8.0 branch December 13, 2017 01:39
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
@lock lock bot unassigned dgquintas Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dgquintas dgquintas dgquintas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mehrdada @grpc-testing @jtattermusch @dgquintas