fix: crash when process name filter longer than 7 #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues in the codes related to the
process name filterthat result in a crash when the provided process name exceeds 7 characters in length:The use of
sizeof(Token)does not return the length of the string but instead gives the size of apointer to TCHAR, which is always 8 bytes on theamd64platform.The
strcpy_sfunction crashes when the length of thesrc(the third argument) exceeds thedestsz(the second argument), as observed in my tests.This PR resolves the crash by replacing
strcpy_swith_tcsncpy_s.@4x3-64