Fixed non-functional daylight saving time (DST) detection #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original implementation is using
time.daylightto detect if DST is active and that's not correct since thetime.daylightreturns:The
time.daylighttells us if current timezone uses DST, thus not if the DST is currently active. This leads to condition wheretime.daylightis always 1 and never changes since my timezone always uses DST but of course the DST is active only sometimes.That's why we need to detect if the DST is currently active instead.
The
time.localtime().tm_isdstreturns:This should fix the DST detection.