Merged
Conversation
Deleted logFile smart pointer and getLogFile function. logfile created inside of the statics functions. Debug.cpp can be deleted.
formatted with clang
Contributor
|
Suggestion: put this same code that you write, inside of debug.cpp |
Contributor
Author
|
alright now i do it |
created writeInLogFile function tested in real PS2 and emulator
clang format
Wolf3s
approved these changes
Nov 5, 2023
Contributor
Thanks i aprroved your changes sounds more portable |
h4570
approved these changes
Nov 5, 2023
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The log file works on the emulator but it didn't work on real hardware.
I managed to fix it by changing the smart pointer for a file that opens and closes in the same function. Now it works on emulator and on real hardware.
I tried to make the file open only once and that it can be used many times, just like with the smart pointer, but I couldn't get it to work in the emulator and on a real PS2 at the same time.
Additional Information:
Tested on a PCSX2 1.6.0 emulator
edit: PS2 model 90001
Ulaunchelf 4.43x_isr (mod by israpps)
edit: USB 3.2 DataTraveler Exodia 16GB FAT32
Deleted logFile smart pointer and getLogFile function.
logfile created inside of the statics functions.