Minor fixes #170
Merged
Minor fixes #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wolf3s
reviewed
Nov 13, 2023
| int width, height; | ||
| u8* data; | ||
| unsigned char* data; | ||
| TextureBpp bpp; |
There was a problem hiding this comment.
Well it was really my mistake
There was a problem hiding this comment.
unsigned char makes code more portable.
It was my fault to put u8, u16 and other custom types in all tyra source code...
There was a problem hiding this comment.
I know that, I was thinking changing that for u8 due to it wasn't ready the multiplataform support from that time but seeing back then i should kept lol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #155 by @Wolf3s